-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignore underscore #185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
- Coverage 100% 99.94% -0.06%
==========================================
Files 12 12
Lines 1744 1818 +74
==========================================
+ Hits 1744 1817 +73
- Misses 0 1 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
- Coverage 100% 99.94% -0.06%
==========================================
Files 12 12
Lines 1744 1818 +74
==========================================
+ Hits 1744 1817 +73
- Misses 0 1 +1
Continue to review full report at Codecov.
|
I like it, the one codecov issue is a bit odd and can be fixed later. I'll go ahead and merge, then add changelog notes later. |
Thanks! |
If merged this pull request will add an option for ignore_underscore which allows options to be triggered equivalently such as
option_one
andoptionone
This also applies to sets and subcommands.
The code style is a mimic of what is done for ignore_case so hopefully that should be easy to follow.
There are two failing test cases but they are same issue as #170 so can be removed.