Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore underscore #185

Merged
merged 6 commits into from
Jan 3, 2019
Merged

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Jan 2, 2019

If merged this pull request will add an option for ignore_underscore which allows options to be triggered equivalently such as option_one and optionone

This also applies to sets and subcommands.

The code style is a mimic of what is done for ignore_case so hopefully that should be easy to follow.

There are two failing test cases but they are same issue as #170 so can be removed.

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #185 into master will decrease coverage by 0.05%.
The diff coverage is 98.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage     100%   99.94%   -0.06%     
==========================================
  Files          12       12              
  Lines        1744     1818      +74     
==========================================
+ Hits         1744     1817      +73     
- Misses          0        1       +1
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️
include/CLI/Option.hpp 99.65% <96.29%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d8d4a...8e7d543. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #185 into master will decrease coverage by 0.05%.
The diff coverage is 98.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage     100%   99.94%   -0.06%     
==========================================
  Files          12       12              
  Lines        1744     1818      +74     
==========================================
+ Hits         1744     1817      +73     
- Misses          0        1       +1
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️
include/CLI/Option.hpp 99.65% <96.29%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d8d4a...bebcb9a. Read the comment docs.

@henryiii
Copy link
Collaborator

henryiii commented Jan 3, 2019

I like it, the one codecov issue is a bit odd and can be fixed later. I'll go ahead and merge, then add changelog notes later.

@henryiii henryiii merged commit a831090 into CLIUtils:master Jan 3, 2019
@henryiii
Copy link
Collaborator

henryiii commented Jan 3, 2019

Thanks!

@henryiii henryiii added this to the v1.7 milestone Jan 3, 2019
@phlptp phlptp deleted the add_ignore_underscore branch January 5, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants