Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding check for correct python version for search #149

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Conversation

henryiii
Copy link
Collaborator

This will stop CLI11 from building the single file include automatically if Python is not a supported version. If you force a build, it will give a nice and helpful error.

It also uses the new Python find module of CMake 3.12 if available.

Fixes #148 hopefully.

@codecov
Copy link

codecov bot commented Jul 26, 2018

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #149   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1691   1691           
=====================================
  Hits         1691   1691

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7a75d...3c6a6ed. Read the comment docs.

@henryiii henryiii merged commit e7dc4c2 into master Jul 26, 2018
@henryiii henryiii mentioned this pull request Jul 28, 2018
@henryiii henryiii deleted the python_search branch August 1, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant