Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config #121

Merged
merged 3 commits into from
May 9, 2018
Merged

Config #121

merged 3 commits into from
May 9, 2018

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented May 8, 2018

This reworks Formatters and adds Config.

General changes:

  • Help flags now use new short_circuit property to simplify parsing

Changes to Formatters:

  • Uses shared pointer instead of functional, can be accessed from App
  • Added get_formatter()
  • make_help is used instead of operator()
  • FormatterBase is the minimum required
  • FormatterLambda provides for the easy addition of an arbitrary function

New for Config:

  • Overridable, bidirectional Config
  • ConfigINI provided and used by default
  • Renamed ini to config in many places
  • Has config_formatter() and get_config_formatter()
  • Dropped prefix argument from config_to_str
  • Added ConfigItem

Closes #125.

@codecov
Copy link

codecov bot commented May 8, 2018

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #121   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     12    +1     
  Lines        1646   1669   +23     
=====================================
+ Hits         1646   1669   +23
Impacted Files Coverage Δ
include/CLI/Formatter.hpp 100% <100%> (ø) ⬆️
include/CLI/Config.hpp 100% <100%> (ø)
include/CLI/ConfigFwd.hpp 100% <100%> (ø)
include/CLI/Error.hpp 100% <100%> (ø) ⬆️
include/CLI/Option.hpp 100% <100%> (ø) ⬆️
include/CLI/FormatterFwd.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6d645...5827e84. Read the comment docs.

@henryiii henryiii merged commit d46c2c5 into master May 9, 2018
@henryiii henryiii deleted the shortcircuit branch May 9, 2018 14:08
@henryiii henryiii added this to the v1.6 milestone Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INI creation
1 participant