Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatters #109

Merged
merged 3 commits into from
Apr 30, 2018
Merged

Formatters #109

merged 3 commits into from
Apr 30, 2018

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Apr 24, 2018

Initial work to allow completely customizable fomatters for help printouts. Closes #108.

Done.

  • Coverage
    • Filter subcommand
    • Add help all and test
    • Fix help all spacing
    • Add test with a new formatter
    • Expand with more tests
    • Possibly move OptionFormatter inside AppFormatter~~
    • Move out of using and detail, AppFormatter and AppFormatMode
  • Docs
    • Add tutorial page
    • Add info to readme
    • Add example to readme
    • Fill out changelog

@codecov
Copy link

codecov bot commented Apr 24, 2018

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #109    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files           9     11     +2     
  Lines        1410   1526   +116     
======================================
+ Hits         1410   1526   +116
Impacted Files Coverage Δ
include/CLI/FormatterFwd.hpp 100% <100%> (ø)
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️
include/CLI/Formatter.hpp 100% <100%> (ø)
include/CLI/Option.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/Error.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a061275...22d314a. Read the comment docs.

@henryiii henryiii force-pushed the help branch 3 times, most recently from 4e26c4b to 3492d81 Compare April 28, 2018 13:52
in progress: formatters

Getting closer

Working on apps

One test actually runs

All builds, added filter functions

Reverting a few behavours as needed

Repairs

All tests pass

Fixing error with adding help flag

Labels are simpler mappings, normalized setters

Adding help_all

Adding a few more tests

One more line tested

Adding one more check

Adding to readme

Simplify naming

Adding default constructors

Fixing spacing issues with subcommand all printout

Adding a couple of tests
Removing OptionFormatter

Rename files

Rename to just Formatter

Remove OptionFormatMode (just needs a bool)

Renaming option functions on formatter
@henryiii henryiii merged commit af2ed66 into master Apr 30, 2018
@henryiii henryiii deleted the help branch April 30, 2018 12:17
@henryiii henryiii added this to the v1.6 milestone May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant