Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct data source #59

Merged
merged 1 commit into from
May 16, 2022
Merged

fix: correct data source #59

merged 1 commit into from
May 16, 2022

Conversation

dk-lockdown
Copy link
Collaborator

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #59 (a667a1e) into dev (5c7c967) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #59   +/-   ##
=======================================
  Coverage   30.96%   30.96%           
=======================================
  Files          46       46           
  Lines        5651     5651           
=======================================
  Hits         1750     1750           
  Misses       3726     3726           
  Partials      175      175           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7c967...a667a1e. Read the comment docs.

Copy link
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zackzhangkai
Copy link
Contributor

lgtm

@zhu733756
Copy link
Contributor

LGTM

@dk-lockdown dk-lockdown merged commit 441ae39 into CECTC:dev May 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants