Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support globallock hint #57

Merged
merged 1 commit into from
May 15, 2022
Merged

feature: support globallock hint #57

merged 1 commit into from
May 15, 2022

Conversation

dk-lockdown
Copy link
Collaborator

@dk-lockdown dk-lockdown commented May 14, 2022

ref: #14

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

there are unit test cases.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #57 (a4cc054) into dev (041a9e1) will decrease coverage by 3.25%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##              dev      #57      +/-   ##
==========================================
- Coverage   34.22%   30.96%   -3.26%     
==========================================
  Files          42       46       +4     
  Lines        4947     5651     +704     
==========================================
+ Hits         1693     1750      +57     
- Misses       3085     3726     +641     
- Partials      169      175       +6     
Impacted Files Coverage Δ
pkg/filter/dt/executor.go 4.53% <0.00%> (ø)
pkg/filter/dt/filter_mysql.go 17.24% <84.84%> (ø)
pkg/filter/dt/filter_http.go 3.44% <0.00%> (ø)
pkg/filter/dt/transaction.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041a9e1...a4cc054. Read the comment docs.

@adofsauron
Copy link

lgtm

@dk-lockdown dk-lockdown merged commit 5c7c967 into CECTC:dev May 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants