Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support prefix match and regex match #151

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Conversation

dk-lockdown
Copy link
Collaborator

ref: #148
ref: #149

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

there are unit test cases.

Ⅳ. Describe how to verify it

check ci result

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #151 (ebc9aef) into dev (3642536) will decrease coverage by 3.53%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##              dev     #151      +/-   ##
==========================================
- Coverage   50.51%   46.97%   -3.54%     
==========================================
  Files          64       69       +5     
  Lines        6590     7127     +537     
==========================================
+ Hits         3329     3348      +19     
- Misses       2953     3470     +517     
- Partials      308      309       +1     
Impacted Files Coverage Δ
pkg/filter/dt/transaction.go 0.00% <0.00%> (ø)
pkg/filter/dt/filter_http.go 16.34% <27.77%> (ø)
pkg/filter/dt/filter_mysql_query.go 0.00% <0.00%> (ø)
pkg/filter/dt/filter_mysql_prepare.go 0.00% <0.00%> (ø)
pkg/filter/dt/filter_mysql.go 1.51% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3642536...ebc9aef. Read the comment docs.

pkg/filter/dt/filter_http.go Outdated Show resolved Hide resolved
pkg/filter/dt/filter_http.go Outdated Show resolved Hide resolved
dk-lockdown and others added 2 commits June 13, 2022 11:29
@bohehe
Copy link
Collaborator

bohehe commented Jun 13, 2022

LGTM

1 similar comment
@fatelei
Copy link
Collaborator

fatelei commented Jun 13, 2022

LGTM

@dk-lockdown dk-lockdown merged commit cdb757a into CECTC:dev Jun 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants