Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should sort the columns #131

Merged
merged 1 commit into from
Jun 6, 2022
Merged

fix: should sort the columns #131

merged 1 commit into from
Jun 6, 2022

Conversation

dk-lockdown
Copy link
Collaborator

@dk-lockdown dk-lockdown commented Jun 6, 2022

otherwise the primary key index obtained is wrong

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

no need

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@dk-lockdown dk-lockdown changed the title fix: should sort the columns, otherwise the primary key index obtaine… fix: should sort the columns Jun 6, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #131 (618c6f4) into dev (dbf2287) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #131   +/-   ##
=======================================
  Coverage   45.83%   45.83%           
=======================================
  Files          62       62           
  Lines        6351     6351           
=======================================
  Hits         2911     2911           
  Misses       3167     3167           
  Partials      273      273           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbf2287...618c6f4. Read the comment docs.

@fatelei
Copy link
Collaborator

fatelei commented Jun 6, 2022

LGTM

@adofsauron
Copy link

LGTM

@dk-lockdown dk-lockdown merged commit f3bc97f into CECTC:dev Jun 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants