Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced numpy.rank() with numpy.ndim(), adding test_setdimattribute* #387

Merged
merged 1 commit into from
Feb 6, 2020
Merged

replaced numpy.rank() with numpy.ndim(), adding test_setdimattribute* #387

merged 1 commit into from
Feb 6, 2020

Conversation

muryanto1
Copy link
Member

No description provided.

jasonb5
jasonb5 approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@jasonb5 jasonb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jasonb5 jasonb5 mentioned this pull request Feb 6, 2020
Closed
@muryanto1 muryanto1 merged commit 34cec4f into master Feb 6, 2020
@muryanto1
Copy link
Member Author

This is for fixing #384

@muryanto1 muryanto1 deleted the fixes_for_numpy_1.18 branch February 26, 2020 18:31
@jasonb5 jasonb5 linked an issue Jul 8, 2020 that may be closed by this pull request
While importing cdms2 error pops up: ImportError: cannot import name 'rank' #396
Closed
@xylar xylar mentioned this pull request Jul 19, 2020
Closed
@jasonb5 jasonb5 added this to the 8.2.1 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonb5 jasonb5 jasonb5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.

While importing cdms2 error pops up: ImportError: cannot import name 'rank'
3 participants
@muryanto1 @jasonb5 @LinaMuryanto