Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better comparison with icu #129

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

robertbastian
Copy link
Contributor

No description provided.

@BurntSushi
Copy link
Owner

Thank you! This is very helpful.

I updated this branch to tweak the code example a bit, and made it pass cargo test --doc (since COMPARE.md is included in the rustdoc).

I think the biggest change is probably removing the as casts in favor of u8::try_from(...).unwrap().

I am hoping to do a jiff-icu crate, following the discussion at #50, at some point to make the conversions a bit simpler, unless y'all get to it first.

@robertbastian
Copy link
Contributor Author

LGTM

@BurntSushi BurntSushi merged commit fee9e9f into BurntSushi:master Sep 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants