Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a modal is opened, the content shifts if at least one scrollbar is present. This PR fixes the most common case with a vertical scrollbar and LTR flow.
Bootstrap reference: https://github.com/twbs/bootstrap/blob/f2e15458da24a089356e3de42df8297f6140059e/js/src/modal.js#L295-L308
Before:
notice the "About" text shifting
2022-11-21.19-53-04.mp4
After:
* shift begone *
2022-11-21.20-13-10.mp4
This PR also changes the after-close cleanup logic to respect whatever values were there before we touched them. Old behavior would break pages that prevent
overflow
on body at all.Resolves #489