Refactor 'check_view_exists' logic #5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents proxy from failing on startup due to faulty logic
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Pending Run on db with 14M rows, and confirm no ui timeouts |
|
Ui timeouts still occur at 1m+ rows in spend logs. But the proxy startup problem is gone. Let's merge this PR and start another one to build on this -> solve the ui timeout issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix(proxy/utils.py): comment out auto-upsert logic in check_view_exists
Relevant issues
Prevents proxy from failing on startup due to faulty logic
Prevent UI timeout errors due to large SpendLogs Table
Type
🐛 Bug Fix
🧹 Refactoring
Changes
[REQUIRED] Testing - Attach a screenshot of any new tests passing locall
If UI changes, send a screenshot/GIF of working UI fixes