Update lago.py to accomodate API change #5495
Conversation
external_customer_id is deprecated. external_subscription_id is the replacement.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @rawwerks can you share a screenshot of this working as expected. My understanding of this doc is that you need to pass in 
|
|
nope, instead of, not in addition to. see the minus sign in that image of the diff? as @jdenquin wrote here: #5477 (comment) - this is to be used instead of. he can confirm if you don't believe me. look at https://docs.getlago.com/api-reference/events/usage#send-usage-event, no sign of read this thread: https://lago-community.slack.com/archives/C03MCH55EL8/p1725409719662939?thread_ts=1725407568.186619&cid=C03MCH55EL8
|
|
Got it. Can you confirm the change works for you as expected (screenshot would be great) |
|
Lago founder here. Indeed, the external customer id is no longer supported. To ingest high volume usage and enable multiple subscriptions for the same customer, we ask our users to send the external subscription id instead. Happy to help and guide you if needed |
|
i really need Lago to start using LiteLLM proxy in production...this is a 1 LOC change, when can we expect to be merged? |
|
Hi @rawwerks merge is blocked on this
I should've made that clearer |
|
merging to a dev branch for testing |
|
will take care of pushing this pr to prod |
* Update lago.py to accomodate API change (#5495) external_customer_id is deprecated. external_subscription_id is the replacement. * fix(lago.py): fixes \ --------- Co-authored-by: Raymond Weitekamp <19483938+rawwerks@users.noreply.github.com>
* Update lago.py to accomodate API change (#5495) external_customer_id is deprecated. external_subscription_id is the replacement. * fix(lago.py): fixes \ --------- Co-authored-by: Raymond Weitekamp <19483938+rawwerks@users.noreply.github.com>
|
great, thank you so much. i have been having a lot of trouble testing this locally, because it seems to require networking two docker containers together. (which i'm not familiar with) related: are there specific instructions for using github actions to build the litellm docker image using GitHub Packages? specifically for the lago integration (and probably other callbacks), i think it is probably better to test it out with both the litellm proxy and lago running on separate servers. building/publishing docker images seems fairly straightforward (https://docs.github.com/en/actions/use-cases-and-examples/publishing-packages/publishing-docker-images) - but if there are instructions specific to litellm you can provide - that would help me better contribute to the development of the proxy server. (related: https://discord.com/channels/1123360753068540065/1280869330170417243 ) |
external_customer_id is deprecated.
external_subscription_id is the replacement.
closes #5477
Title
Relevant issues
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes
[REQUIRED] Testing - Attach a screenshot of any new tests passing locall
If UI changes, send a screenshot/GIF of working UI fixes