-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
astra-assistants api support #4118
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
related to #2842 |
Hi folks, checking in here. Would appreciate a review @ishaan-jaff @krrishdholakia |
Hi folks, would appreciate some feedback on this PR @krrishdholakia @ishaan-jaff |
|
||
|
||
|
||
class AstraAssistantsAPI(OpenAIAssistantsAPI): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't see why this needs to exist as a separate file / if-else block in all the assistant api endpoints.
If it's openai-compatible, all you need to do is update get_llm_provider
like we do for groq
and this should work without major changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool, I didn't realize that thanks!
Will fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to just update get_llm_provider
and add astra_assistants to the list of openai-compatible providers.
astra-assistants api support
Assistants API support for astra-assistants (an open source based drop in compatible Assistants API service that supports third party LLMs and embeddings)
Type
🆕 New Feature
✅ Test
📖 Documentation
Changes
[REQUIRED] Testing -
Extended existing assistants tests to cover
astra-assistants
providerTest procedure: