Fix function call arg #3917
Open
Fix function call arg #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
paneru-rajan
suggested changes
May 31, 2024
| @@ -275,6 +275,7 @@ def log_event( | |||
| response_obj=response_obj, | |||
| start_time=start_time, | |||
| end_time=end_time, | |||
| end_user_id=None, | |||
There was a problem hiding this comment.
you mean user_id here instead of end_user_id?
There was a problem hiding this comment.
No... Here is the function definition for get_logging_payload at litellm.proxy.utils
def get_logging_payload(
kwargs, response_obj, start_time, end_time, end_user_id: Optional[str]
):
from litellm.proxy._types import LiteLLM_SpendLogs
....
As I was reading through the code, I found the required param is not passed. Since its not passed, I hope setting value as None is what expected. But we do have a param called user_id from the parent function.
@krrishdholakia Should None replaced with user_id ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Some required parameters of function call are not passed
Type
🐛 Bug Fix
🧹 Refactoring
Changes
See commit message