-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #542 allow system messages + chat for palm api #3718
Open
SujanShilakar
wants to merge
3
commits into
BerriAI:main
Choose a base branch
from
paneru-rajan:Issue-542-allow-message
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SujanShilakar
force-pushed
the
Issue-542-allow-message
branch
from
May 18, 2024 05:08
571397c
to
180a4e2
Compare
Fixes #542 |
paneru-rajan
suggested changes
May 18, 2024
SujanShilakar
force-pushed
the
Issue-542-allow-message
branch
from
May 19, 2024 07:30
180a4e2
to
1ce93e6
Compare
SujanShilakar
changed the title
Issue number 542 allow system messages + chat for palm api
Fixes #542 allow system messages + chat for palm api
May 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow system messages + chat messages in palm api
Fixes #542
🆕 New Feature
Modified completion Function:
Constructed a prompt string from context and messages.
Used the prompt string in the API call to palm.generate_text.
Logging Adjustments:
Updated pre-call and post-call logging to handle the new input structure as a single prompt.
Response Handling:
Adjusted the response processing to handle the structured response from the Palm API.
cc: @krrishdholakia / @ishaan-jaff