Clean up prod prints - Convert print to log #3667
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
requested changes
May 16, 2024
The production logs are messy because of all the print statements. Ideally, everything should be logged using a proper logging library, not print. This repository has many print statements, but some files allow you to disable them with a verbose flag. However, this flag isn't used consistently across all files. Even after disabling the verbose mode for the littlem, there are still many print statements. Therefore, we need to standardize the way we disable them using a single, consistent verbose flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
The production logs are messy because of all the print statements. Ideally, everything should be logged using a proper logging library, not print. This repository has many print statements, but some files allow you to disable them with a verbose flag. However, this flag isn't used consistently across all files.
Even after disabling the verbose mode for the littlem, there are still many print statements. Therefore, we need to standardize the way we disable them using a single, consistent verbose flag.
Relevant issues
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes
[REQUIRED] Testing - Attach a screenshot of any new tests passing locall
If UI changes, send a screenshot/GIF of working UI fixes