-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(helm-chart): use default environment variable for master key #2432
base: main
Are you sure you want to change the base?
chore(helm-chart): use default environment variable for master key #2432
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This makes sense. Or even just bypass the file as an option. Some logic like:
Otherwise fallback to disable master key security. |
good to merge @debdutdeb @GuillermoBlasco ? |
@GuillermoBlasco you're right .. we should put an So if there is the value in Values file, we set LITELLM_MASTER_KEY. If it's in config like And if somebody put it inside the config as a literal, well, if Im not mistaken you're saying we do something like
If that's the case, IMO we let them do it as is? 🙈 this is the kind of helm magic that in my experience creates more pain when multiple team members are considered, and honestly there are better ways to handle it within chart wth envFrom, and whomever deploying should take care of that themselves? IDK if you folks think we should do it that way, I can add those couple lines in :) Sorry @ishaan-jaff did not receive the notification first time. Please let's wait for Gui's input. |
what're next steps on this? @debdutdeb @GuillermoBlasco @ishaan-jaff |
@ishaan-jaff this should be ready to merge :) |
Sometimes these manifests are used as a reference to some documentation. Idea is to use a the default environment variable instead of something specific and different baked into just the chart.
It may be that somebody doesn't want to put key in values file. They can set the key something like
Then have a secret referenced with the key