Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addHosts/delHosts methods #6

Merged
merged 13 commits into from
Sep 26, 2016
Merged

Add addHosts/delHosts methods #6

merged 13 commits into from
Sep 26, 2016

Conversation

kirill-k-roxot
Copy link
Collaborator

Hello!

Let me thank you in public for such a simple yet great tool.

I updated the code, the changes are following:

  • added addHosts and delHosts method, allowing to specify just the record to add, not the full list, as setHosts demands
  • added internal _elements_names_fix method to allow use both Name / HostName and Type / RecordType filed name pairs
  • updated tests accordingly
  • updated README.md with basic usage examples of new methods

The reason files looks ~95% rewritten are pep8/markdown warnings:

  • replaced tabs with 4x white-spaces
  • replaced def x(a = 1) with def x(a=1)
  • replaced { a: 5 } with {a: 5}

In fact, only 2 stated methods were added.

Feel free to review the code and comment if you want me to rollback some changes I made.

@kirill-k-roxot
Copy link
Collaborator Author

I also added CLI tool to simplify records management.

Let me know if you'd like to merge it in.

@kirill-k-roxot kirill-k-roxot merged commit 809f997 into Bemmu:master Sep 26, 2016
@kirill-k-roxot
Copy link
Collaborator Author

Added both new methods and CLI tool.

Thanks!

agrrh added a commit that referenced this pull request Sep 27, 2016
Add addHosts/delHosts methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants