Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3777: Fix testing logic in tests/testing/asserters_test.py #3778

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Sep 18, 2024

Closes #3777: Fix testing logic in tests/testing/asserters_test.py

Here is an example where the logic was not quite right:

        with pytest.raises(AssertionError):
            if both_ak:
                assert_arkouda_array_equal(c, c2)
            assert_arkouda_array_equivalent(convert_left(c), convert_right(c2))

In this case, the second assert will not execute when both_ak=True. This PR fixes the issue throughout the file.

@ajpotts ajpotts marked this pull request as ready for review September 18, 2024 15:09
@ajpotts ajpotts changed the title Closes #3777: Fix testing login in tests/testing/asserters_test.py Closes #3777: Fix testing logic in tests/testing/asserters_test.py Sep 18, 2024
@ajpotts ajpotts force-pushed the 3777-Fix-testing-logic-in-tests/testing/asserters_test.py branch 3 times, most recently from 8479ebc to e6fc077 Compare September 19, 2024 13:26
@ajpotts ajpotts force-pushed the 3777-Fix-testing-logic-in-tests/testing/asserters_test.py branch from e6fc077 to 1aa215f Compare September 20, 2024 16:22
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks

@stress-tess stress-tess added this pull request to the merge queue Sep 25, 2024
Merged via the queue into Bears-R-Us:master with commit 1d36d7d Sep 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix testing logic in tests/testing/asserters_test.py
2 participants