Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3731: Add skip_if_max_rank_less_than markers to numeric_test… #3732

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Closes #3731: Add skip_if_max_rank_less_than markers to numeric_test… #3732

merged 1 commit into from
Aug 30, 2024

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Aug 30, 2024

Add skip_if_max_rank_less_than markers to numeric_tests.py instead of using:

        if get_max_array_rank() < 2:
            pytest.skip()

Closes #3731: Add skip_if_max_rank_less_than markers to numeric_test…

@ajpotts ajpotts marked this pull request as ready for review August 30, 2024 19:57
@stress-tess stress-tess added this pull request to the merge queue Aug 30, 2024
Merged via the queue into Bears-R-Us:master with commit e08b0db Aug 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stress-tess stress-tess stress-tess approved these changes

@drculhane drculhane Awaiting requested review from drculhane

@jaketrookman jaketrookman Awaiting requested review from jaketrookman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add skip_if_max_rank_less_than markers to numeric_tests.py
2 participants
@ajpotts @stress-tess