Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3656: Refactor LinalgMsg.transpose to use registerCommand #3693

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Aug 26, 2024

Refactors LinalgMsg.transpose to use @registerCommand which is slightly more efficient.

Closes #3656: Refactor LinalgMsg.transpose to use registerCommand

@ajpotts ajpotts marked this pull request as ready for review August 26, 2024 16:22
@ajpotts ajpotts force-pushed the 3656-Refactor-LinalgMsg.transpose-to-use-registerCommand branch from a900012 to 1b5320d Compare August 26, 2024 16:23
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor suggestion:

src/LinalgMsg.chpl Outdated Show resolved Hide resolved
@ajpotts ajpotts force-pushed the 3656-Refactor-LinalgMsg.transpose-to-use-registerCommand branch from 4379624 to 806b690 Compare August 27, 2024 16:59
@stress-tess stress-tess added this pull request to the merge queue Aug 28, 2024
Merged via the queue into Bears-R-Us:master with commit c36172a Aug 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor LinalgMsg.transpose to use registerCommand
4 participants