Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3632: refactor LinalgMsg to remove registerND annotation #3633

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Aug 7, 2024

Refactors LinalgMsg to remove registerND annotation and replace with @arkouda.instantiateAndRegister.

@drculhane did all the work on this one, I'm just helping to submit the PR.

Closes #3632: refactor LinalgMsg to remove registerND annotation

@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch from 5688355 to 82ef5d2 Compare August 7, 2024 15:08
@drculhane
Copy link
Contributor

(1) You made excellent improvements; thanks.
(2) I'm having unusual problems making and testing this. I'm assuming that once again, it's most likely my VM. I'll probably post another comment with a summary later today.

@drculhane
Copy link
Contributor

Okay, here's my follow-up.

(1) Had to increase my VM RAM to 32GB to make with max-array-rank of 3. My RevisedDraft3422 would make in 24GB (but not 16). I have no explanation for this.

(2) Some tests hung with max-array-rank < 3. With 3, all pass (or skip) except for two (in client_test.py): test_client_get_config and test_client_array_dim_cmd_error , which are hardcoded to expect max-array-rank of 1.

Those client_test.py tests are fixed in RevisedDraft3422, but when Amanda suggested splitting it into smaller PRs for evaluation, it slipped my mind that client_test.py needed to be part of the first one (and I'm not sure that this belongs in client_test anyway, but I don't have strong feelings about it).

@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch 10 times, most recently from 6ee2c5e to 0b19178 Compare August 9, 2024 15:16
@ajpotts ajpotts marked this pull request as ready for review August 9, 2024 15:17
@ajpotts
Copy link
Contributor Author

ajpotts commented Aug 9, 2024

I did end up making some minor changes to LinalgMsg to streamline code a little. I also changed one of the tests in client_test.py. Let me know what you think.

@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch 2 times, most recently from 6d132b3 to 2f5039a Compare August 9, 2024 17:25
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! I have a couple of (very optional) suggestions on how to further simplify the server code:

src/LinalgMsg.chpl Show resolved Hide resolved
src/LinalgMsg.chpl Outdated Show resolved Hide resolved
@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch from 2f5039a to 7510470 Compare August 13, 2024 15:24
@ajpotts ajpotts marked this pull request as draft August 13, 2024 19:23
@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch from e3f46d5 to ea0cd3b Compare August 13, 2024 20:24
@ajpotts ajpotts marked this pull request as ready for review August 13, 2024 20:24
arkouda/numeric.py Outdated Show resolved Hide resolved
Copy link
Contributor

@drculhane drculhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one of my "oops, I should have removed that" comments at line 2260 in numeric.py, but if that makes it through this PR, we'll take it out in the next one.

arkouda/numeric.py Outdated Show resolved Hide resolved
@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch from 076074a to 3ca8a40 Compare August 14, 2024 14:47
@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch 2 times, most recently from 9827eeb to 42f9cc3 Compare August 14, 2024 14:59
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions, but I don't see any logic issues!

PROTO_tests/tests/numeric_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/numeric_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/numeric_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/numeric_test.py Outdated Show resolved Hide resolved
src/LinalgMsg.chpl Outdated Show resolved Hide resolved
@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch from 670f3f2 to d5b6a53 Compare August 14, 2024 20:53
@ajpotts ajpotts marked this pull request as draft August 14, 2024 22:24
@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch from e8cb736 to b50e40b Compare August 14, 2024 22:46
@ajpotts ajpotts marked this pull request as ready for review August 14, 2024 22:50
@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch 2 times, most recently from 44dc645 to cca2778 Compare August 15, 2024 12:05
…ation

Co-authored-by: drculhane <drculhane@users.noreply.github.com>
@ajpotts ajpotts force-pushed the 3632-refactor-LinalgMsg-to-remove-registerND-annotation branch from cca2778 to 6465553 Compare August 16, 2024 17:53
@stress-tess stress-tess added this pull request to the merge queue Aug 21, 2024
@stress-tess stress-tess removed this pull request from the merge queue due to the queue being cleared Aug 21, 2024
@stress-tess stress-tess added this pull request to the merge queue Aug 21, 2024
Merged via the queue into Bears-R-Us:master with commit 2efe473 Aug 21, 2024
10 checks passed
@ajpotts ajpotts mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor LinalgMsg to remove registerND annotation
5 participants