-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3632: refactor LinalgMsg to remove registerND annotation #3633
Closes #3632: refactor LinalgMsg to remove registerND annotation #3633
Conversation
5688355
to
82ef5d2
Compare
(1) You made excellent improvements; thanks. |
Okay, here's my follow-up. (1) Had to increase my VM RAM to 32GB to make with max-array-rank of 3. My RevisedDraft3422 would make in 24GB (but not 16). I have no explanation for this. (2) Some tests hung with max-array-rank < 3. With 3, all pass (or skip) except for two (in client_test.py): test_client_get_config and test_client_array_dim_cmd_error , which are hardcoded to expect max-array-rank of 1. Those client_test.py tests are fixed in RevisedDraft3422, but when Amanda suggested splitting it into smaller PRs for evaluation, it slipped my mind that client_test.py needed to be part of the first one (and I'm not sure that this belongs in client_test anyway, but I don't have strong feelings about it). |
6ee2c5e
to
0b19178
Compare
I did end up making some minor changes to |
6d132b3
to
2f5039a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! I have a couple of (very optional) suggestions on how to further simplify the server code:
2f5039a
to
7510470
Compare
e3f46d5
to
ea0cd3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one of my "oops, I should have removed that" comments at line 2260 in numeric.py, but if that makes it through this PR, we'll take it out in the next one.
076074a
to
3ca8a40
Compare
9827eeb
to
42f9cc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggestions, but I don't see any logic issues!
670f3f2
to
d5b6a53
Compare
e8cb736
to
b50e40b
Compare
44dc645
to
cca2778
Compare
…ation Co-authored-by: drculhane <drculhane@users.noreply.github.com>
cca2778
to
6465553
Compare
Refactors LinalgMsg to remove registerND annotation and replace with @arkouda.instantiateAndRegister.
@drculhane did all the work on this one, I'm just helping to submit the PR.
Closes #3632: refactor LinalgMsg to remove registerND annotation