Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoolingLayer customizable output shape rounding mode #6282

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

Noiredd
Copy link
Member

@Noiredd Noiredd commented Mar 7, 2018

Resurrection of #3057 which allowed the user to choose how is the pooling output shape calculated, as there is confusion between how does the PoolingLayer do it and how does ConvolutionLayer (see @jeffdonahue's note on this).

This implementation incorporates @seanbell's idea to have the rounding mode as an enum.

Fixes #1318
Closes #3057

@shaibagon
Copy link
Member

@Noiredd thank you for resurrecting #3057, what keeps you from merging this PR?

@ghost
Copy link

ghost commented Jul 13, 2018

+1 for merging this!

@Noiredd Noiredd merged commit 24b0905 into BVLC:master Aug 17, 2018
@Noiredd Noiredd deleted the pooling-mode branch August 17, 2018 09:54
@Noiredd
Copy link
Member Author

Noiredd commented Aug 17, 2018

Sorry for a long delay, I've been tied up with work. I'll try to catch up with PRs and issues in the following days.

XinYao1994 pushed a commit to XinYao1994/caffe that referenced this pull request Aug 29, 2018
PoolingLayer customizable output shape rounding mode
beniz pushed a commit to jolibrain/caffe that referenced this pull request Sep 24, 2018
PoolingLayer customizable output shape rounding mode
Copy link

@lianglin74 lianglin74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!

keerthanss added a commit to keerthanss/DenseNet-Caffe that referenced this pull request Feb 27, 2019
ceil_mode was proposed in BVLC/caffe#3057 , but never merged. Its replacement, BVLC/caffe#6282 , fulfils the same need with some syntactic variance. The param is now called "round_mode" and it is an enum, instead of a boolean. This commit modifies the files accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants