Fix Crop layer dimension checking to only check cropped dimensions #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check only the dimensions to be cropped for compatible sizes and offsets
|
Reported with fix in #3778 by wk910930—thanks for noting the issue! |
shelhamer
added a commit
to shelhamer/fcn.berkeleyvision.org
that referenced
this pull request
Apr 21, 2016
BVLC/caffe#3993 fixed the Crop layer checks to not refuse valid crop shapes.
fxbit
pushed a commit
to Yodigram/caffe
that referenced
this pull request
Sep 1, 2016
Fix Crop layer dimension checking to only check cropped dimensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Croplayer should only check the actual dimensions to be cropped for shape compatibility given the crop size and offset.The current, over-general check results in issues like refusing to crop the output for a binary classification task given color input, since the data has 3 channels while the output has 2. As the channels are not cropped (in this use case) that is irrelevant and wrong.
This PR fixes the check, makes the message clearer, and revises the comments here and there.