Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified CropLayer #3565

Closed
wants to merge 1 commit into from
Closed

Simplified CropLayer #3565

wants to merge 1 commit into from

Conversation

BlGene
Copy link
Contributor

@BlGene BlGene commented Jan 18, 2016

This is for cropping one blob to another using coordinates from parameters.

continues from PR #1976.

@longjon
Copy link
Contributor

longjon commented Jan 19, 2016

Thanks for posting this, this is basically what I had in mind in #1976. However, the more substantial task (which I haven't attempted yet) is to build the ND version. I think it would need an interface similar to the current convolution one, i.e., an axis param and a repeated crop param. The former would indicate that dimensions following the indicated one were spatial dimensions, while the latter would either be specified once, indicating that all spatial dimensions should be cropped the same amount, or specified a number of times equal to the number of spatial dimensions. Feel free to take a stab at that if you like!

I do already have a private version of the Python code mentioned in #1976. I'll try to open a PR for that shortly, whether completely finished or not.

@BlGene BlGene mentioned this pull request Jan 19, 2016
8 tasks
@BlGene
Copy link
Contributor Author

BlGene commented Mar 1, 2016

Closing in favor of #3570.

@BlGene BlGene closed this Mar 1, 2016
@BlGene BlGene deleted the crop-layer-rebase branch March 6, 2016 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants