Check that the snapshot directory is writeable before starting training #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be helpful. Thanks @seanbell ! |
| if (!param_.has_snapshot_prefix()) { | ||
| LOG(FATAL) << "In solver params, snapshot is specified " | ||
| << "but snapshot_prefix is not"; | ||
| } |
There was a problem hiding this comment.
A minor issue: better to use CHECK marcos here and below to make code more succinct.
seanbell
force-pushed
the
check-snapshot-prefix
branch
from
a522cea
to
865b6bf
Compare
|
Thanks for the review! I addressed your comments and squashed into a single commit. I left the second FATAL because there is cleanup required if it passes. |
| void Solver<Dtype>::CheckSnapshotWritePermissions() { | ||
| if (Caffe::root_solver() && param_.snapshot()) { | ||
| CHECK(param_.has_snapshot_prefix()) | ||
| << "In solver params, snapshot is specified but snapshot_prefix is not"; |
There was a problem hiding this comment.
Better to indent 4 spaces in continuing lines here and below, to be consistent with our code style.
There was a problem hiding this comment.
OK -- updated to 4 spaces (and below) and rebased again.
seanbell
force-pushed
the
check-snapshot-prefix
branch
from
865b6bf
to
ab554cb
Compare
ronghanghu
added a commit
that referenced
this pull request
Sep 14, 2015
Check that the snapshot directory is writeable before starting training
ctrevino
added a commit
to Robotertechnik/caffe
that referenced
this pull request
Sep 15, 2015
Check that the snapshot directory is writeable before starting training. PR BVLC#3049
ctrevino
added a commit
to Robotertechnik/caffe
that referenced
this pull request
Sep 15, 2015
|
the snapshot directory cannot write when i training the lenent ,what should i do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When training, if a snapshot cannot be written (directory does not exist, or insufficient permissions, or invalid snapshot prefix), a lot of time can potentially be lost waiting for the error. This tries to open an empty test file (and delete it) before training starts, so that failure happens as soon as possible.
This does not check for disk space, but usually that's a problem for later in training.