Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added servicefabric_checklist.en.json - Item ID: C01.01, C01.02, C01.03, C01.04, C01.05, C01.06, C01.07, C01.08 #903

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

cloudsystemsarchitect
Copy link

Description

Added a Azure Service Fabric checklist and specifically for the Security Pillar. All recommendations are based on the Azure Service Fabric Well Architected Framework. This is the second PR specifically for the security pillar.

Related Issue

This is related ADO item 400755.
The PR for reliability pillar is #886
The PR for cost pillar is #899

Checklist

  • I've tested my changes to ensure they are ready for review.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the documentation (if applicable).
  • Resource Graph queries have been included (and tested) for recommendations where ever possible1.
  • [] Resource Graph queries have NOT been included (please explain below).

Additional Information

C01.01
No NSG information found for the resource type Microsoft.ServiceFabric/managedclusters.

C01.02
Screenshot of the test result from the query.
image

C01.03
No ACL information found for the resource type Microsoft.ServiceFabric/managedclusters in ARG.

C01.04
No resource requests/limits information found for the resource type Microsoft.ServiceFabric/managedclusters.

C01.05
This recommendation requires information of the application deployed in the cluster.

C01.06
This recommendation requires information of the application deployed in the cluster.

C01.07
This recommendation requires information of the application deployed in the cluster.

C01.08
This recommendation requires information of the application deployed in the cluster.

Reviewer Notes

Is there a specific area you’d like feedback on? Please highlight it here. We're here to help and learn together! 💡

Footnotes

  1. Details on how to add Azure Resource Graph queries to recommendations can be found here.

@jodyford-msft
Copy link

please add checklist ID and filename to title of PR

@cloudsystemsarchitect cloudsystemsarchitect changed the title Added Azure Service Fabric checklist - Security Pillar Added servicefabric_checklist.en.json - Item ID: C01.01, C01.02, C01.03, C01.04, C01.05, C01.06, C01.07, C01.08 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants