-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added servicefabric_checklist.en.json - Item ID: C01.01, C01.02, C01.03, C01.04, C01.05, C01.06, C01.07, C01.08 #903
Open
cloudsystemsarchitect
wants to merge
15
commits into
Azure:main
Choose a base branch
from
cloudsystemsarchitect:service-fabric-security-pillar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudsystemsarchitect
requested review from
erjosito and
sdolgin
as code owners
September 19, 2024 13:14
please add checklist ID and filename to title of PR |
cloudsystemsarchitect
changed the title
Added Azure Service Fabric checklist - Security Pillar
Added servicefabric_checklist.en.json - Item ID: C01.01, C01.02, C01.03, C01.04, C01.05, C01.06, C01.07, C01.08
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a Azure Service Fabric checklist and specifically for the Security Pillar. All recommendations are based on the Azure Service Fabric Well Architected Framework. This is the second PR specifically for the security pillar.
Related Issue
This is related ADO item 400755.
The PR for reliability pillar is #886
The PR for cost pillar is #899
Checklist
Additional Information
C01.01
No NSG information found for the resource type Microsoft.ServiceFabric/managedclusters.
C01.02
Screenshot of the test result from the query.
C01.03
No ACL information found for the resource type Microsoft.ServiceFabric/managedclusters in ARG.
C01.04
No resource requests/limits information found for the resource type Microsoft.ServiceFabric/managedclusters.
C01.05
This recommendation requires information of the application deployed in the cluster.
C01.06
This recommendation requires information of the application deployed in the cluster.
C01.07
This recommendation requires information of the application deployed in the cluster.
C01.08
This recommendation requires information of the application deployed in the cluster.
Reviewer Notes
Is there a specific area you’d like feedback on? Please highlight it here. We're here to help and learn together! 💡
Footnotes
Details on how to add Azure Resource Graph queries to recommendations can be found here. ↩