Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Data Landing Zone Subs to Storage Firewall #223

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Add Data Landing Zone Subs to Storage Firewall #223

merged 3 commits into from
Jan 10, 2022

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Dec 23, 2021 •
edited
Loading

Summary of the Pull Request

This PR adds resource rules for all Data Landing Zone subcriptions to the Data Lakes. This allows cross-Data Landing Zone data access using SQL Pools and SQL serverless within DMA. It also fixes a few Bicep linting issues.

References

None

PR Checklist

Validation Steps Performed

See comments and runs below.

@marvinbuss marvinbuss added feature Feature Requests committed Committed item labels Dec 23, 2021
@marvinbuss marvinbuss added this to the v1.3.0 milestone Dec 23, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner December 23, 2021 09:18
@marvinbuss marvinbuss self-assigned this Dec 23, 2021
@marvinbuss marvinbuss linked an issue Dec 23, 2021 that may be closed by this pull request
Feature Request: Add all Data Landing Zone Subscriptions in Storage Firewall #219
Closed
marvinbuss
marvinbuss commented Dec 23, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marvinbuss
marvinbuss commented Dec 23, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss
Copy link
Collaborator Author

Preview Link

@marvinbuss marvinbuss mentioned this pull request Dec 23, 2021
Merged
2 tasks
@marvinbuss
Copy link
Collaborator Author

Resource Access rules are correctly set. See image below:
image

amanjeetsingh
amanjeetsingh approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@marvinbuss marvinbuss merged commit 5342b57 into main Jan 10, 2022
@marvinbuss marvinbuss deleted the marvinbuss/add_dlz_subscriptions branch January 10, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanjeetsingh amanjeetsingh amanjeetsingh approved these changes

Assignees

@marvinbuss marvinbuss

Labels
committed Committed item feature Feature Requests
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Add all Data Landing Zone Subscriptions in Storage Firewall
2 participants
@marvinbuss @amanjeetsingh