Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Synapse Pools from default setup #182

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Remove Synapse Pools from default setup #182

merged 2 commits into from
Sep 16, 2021

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Sep 15, 2021 •
edited
Loading

This PR fixes

  • It removes the Synapse Spark pool and SQL pool from the deployment. This shared synapse instance is not something that is generally not used due to limitations on visibility of code artifacts and single git connection. Hence, these will most likely be deployed as part of the product deployments and can be removed from the core landing zone setup.

@marvinbuss marvinbuss added the enhancement New feature or request label Sep 15, 2021
@marvinbuss marvinbuss self-assigned this Sep 15, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner September 15, 2021 11:41
marvinbuss
marvinbuss commented Sep 15, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sasever
sasever approved these changes Sep 15, 2021
View reviewed changes
Copy link

@sasever sasever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to Go :)

@marvinbuss marvinbuss merged commit 0fc8279 into main Sep 16, 2021
@marvinbuss marvinbuss deleted the marvinbuss/remove_synapse_pools branch September 16, 2021 13:15
@marvinbuss marvinbuss mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasever sasever sasever approved these changes

@esbran esbran Awaiting requested review from esbran

@amanjeetsingh amanjeetsingh Awaiting requested review from amanjeetsingh

Assignees

@marvinbuss marvinbuss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinbuss @sasever