Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing duplicate tags #1817

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fixing duplicate tags #1817

merged 1 commit into from
Oct 28, 2022

Conversation

Blackmist
Copy link
Contributor

When there's duplicate XML style tags used for import into docs, the last one is the one that matches. Changing tag to be unique.

PR into Azure/azureml-examples

Checklist

I have:

  • [ x ] read and followed the contributing guidelines

Changes

Changed comments to have a unique xml-style name

fixes #

When there's duplicate XML style tags used for import into docs, the last one is the one that matches. Changing tag to be unique.
@Blackmist
Copy link
Contributor Author

@shohei1029 @dem108 can someone merge? Unblocking snippet import into docs.

@dem108
Copy link
Contributor

dem108 commented Oct 28, 2022

Thanks for catching this! Do we need a PR for docs update too?

Copy link
Contributor

@dem108 dem108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks!

@Blackmist
Copy link
Contributor Author

Blackmist commented Oct 28, 2022

Thanks for catching this! Do we need a PR for docs update too?

Working on the doc also. Getting ready to open another PR though - looks like the name the model is registered as (sklearn) isn't what the deployment uses (score-sklearn).

@shohei1029 shohei1029 self-requested a review October 28, 2022 15:35
@shohei1029
Copy link
Contributor

Thanks for the PR! I'll merge it.

@shohei1029 shohei1029 merged commit ef36031 into main Oct 28, 2022
@shohei1029 shohei1029 deleted the Blackmist-patch-1 branch October 28, 2022 15:36
vs-li pushed a commit to vs-li/azureml-examples that referenced this pull request May 12, 2023
When there's duplicate XML style tags used for import into docs, the last one is the one that matches. Changing tag to be unique.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants