Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Signing Command for use in dUSD #21

Merged
merged 20 commits into from
Oct 5, 2022
Merged

Add Signing Command for use in dUSD #21

merged 20 commits into from
Oct 5, 2022

Conversation

Geometer1729
Copy link
Contributor

@Geometer1729 Geometer1729 commented Aug 31, 2022 •
edited
Loading

Closes #20

The issue says server but we decided a cli was a better plan

This pr will add support to sign txs with a signing command

@epiro-ps epiro-ps mentioned this pull request Aug 31, 2022
Closed
@Geometer1729 Geometer1729 marked this pull request as ready for review October 4, 2022 13:51
@Geometer1729 Geometer1729 changed the title Signing Server Add Signing Command for use in dUSD Oct 4, 2022
epiro-ps
epiro-ps approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@epiro-ps epiro-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic. Just a few things - would love to see cabal testing added to the nix flake checks, some documentation, and some clean-up.

flake.nix Show resolved Hide resolved
app/Main.hs Outdated Show resolved Hide resolved
src/Api.hs Show resolved Hide resolved
tests/Main.hs Outdated Show resolved Hide resolved
tests/Main.hs Outdated Show resolved Hide resolved
epiro-ps
epiro-ps suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@epiro-ps epiro-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to block merge with change request.

@Geometer1729 Geometer1729 mentioned this pull request Oct 5, 2022
Merged
3 tasks
epiro-ps
epiro-ps approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@epiro-ps epiro-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice mergeable work here. Here's the ticket for the follow up configuration work to ensure this can be run as dummy and on hardware.

#23

@epiro-ps epiro-ps merged commit 6fc4b46 into main Oct 5, 2022
@epiro-ps epiro-ps deleted the brian/signing branch October 5, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epiro-ps epiro-ps epiro-ps approved these changes

@mlitchard mlitchard Awaiting requested review from mlitchard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signing Server
3 participants
@Geometer1729 @epiro-ps @marijanp