style: Action and Observation use schema for unifying #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are you going to merge this? unifying constant |
|
@iFurySt sorry I missed this one! This seems like a great change--sorry for the rebase pain |
rbren
approved these changes
Apr 5, 2024
|
okay, i handle it later🥳 |
|
@rbren hard to catch up~ appreciate it if you have time to merge it into the main branch. |
|
Thank you! |
lehcode
pushed a commit
to lehcode/oppendevin
that referenced
this pull request
Apr 10, 2024
* style: Action and Observation use schema for unifying * merge from upstream/main * merge from upstream/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only changes the String Literal of Action and Observation to the schema.ActionType and schema.ObservationType.
but I opened the Black Formater, so the change seems like a lot. 😄