Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ad/regression tests using pytest #329

Merged
merged 4 commits into from
Mar 29, 2024
Merged

feat: Ad/regression tests using pytest #329

merged 4 commits into from
Mar 29, 2024

Conversation

dorbanianas
Copy link
Collaborator

rbren
rbren approved these changes Mar 29, 2024
View reviewed changes
evaluation/regression/cases/hello-world/test_hello_world.py Outdated

with open(os.path.join(workspace_dir, 'hello_world.sh'), 'r') as file:
content = file.read().strip()
assert content == '#!/bin/bash\necho "Hello, World!"'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be asserting the output from running the script, not the content iteslf

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to update it, I will adjust it now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ✅

@rbren rbren merged commit 7c27e59 into All-Hands-AI:main Mar 29, 2024
xcodebuild pushed a commit to xcodebuild/OpenDevin that referenced this pull request Mar 31, 2024
@dorbanianas
feat: Ad/regression tests using pytest (All-Hands-AI#329)
0a7bf5c 
* Remove all the unnecessary files

* Create finalize the regression testing framework and add hello world test case

* Update requirements.txt

* Update the test function to execute the generate script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbren rbren rbren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorbanianas @rbren