-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate multi-line-bash-related sandbox tests into runtime tests and fix multi-line issue #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubig/remove_remaining_global_config
xingyaoww
changed the title
[WIP]migrate sandbox tests
[WIP] Migrate sandbox tests into runtime tests
Jul 26, 2024
…ubig/remove_remaining_global_config
support multi-line bash for esruntime;
Closed
12 tasks
add testcases for multi-line commands
xingyaoww
changed the title
[WIP] Migrate sandbox tests into runtime tests
Migrate multi-line-bash-related sandbox tests into runtime tests
Jul 27, 2024
xingyaoww
changed the title
Migrate multi-line-bash-related sandbox tests into runtime tests
Migrate multi-line-bash-related sandbox tests into runtime tests and fix multi-line issue
Jul 27, 2024
neubig
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the quick fix!
update bash parsing logic (fall back to original command when failed); remove unrelavant parsing tests (we don't split ; anymore)
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
We are almost done with the arch refactor for Runtime (#2404). Right now we need to make sure the new runtime has feature parity with existing default
ServerRuntime
before we are ready to switch over to the new architecture.This also fixes #3143
Give a summary of what the PR does, explaining any non-trivial design decisions
Move allIt turns out there's too many things to change, it will be easier for code reviewer if i break this down into separate PRs.test_sandbox.py
tests intotest_runtime.py
to test both Runtime implementation (ServerRuntime
,EventStreamRuntime
).test_sandbox
totest_runtime.
EventStreamRuntime
PS2
to empty, so there's no weird ">" after multi-line bash command executionbashlex
for bash parsing to handle multi-line commands;DEBUG
inlogger
(otherwise it is a bit cumbersome to debug)Other references