Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add od runtime clinet dependencies in sandbox image #2858

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

yufansong
Copy link
Collaborator

@yufansong yufansong commented Jul 8, 2024

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
In order to run runtime client introduced here #2603 in snadbox docker image, we need to add more new dependency. Maybe we will introduce poetry to management this environment, but let's use pip now first.

Give a brief summary of what the PR does, explaining any non-trivial design decisions

Other references

@yufansong yufansong marked this pull request as ready for review July 8, 2024 17:46
@yufansong yufansong requested a review from xingyaoww July 8, 2024 17:46
Copy link
Contributor

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary workaround for #2603.
As next step, we should add:

  • poetry to manage environment inside Runtime docker
  • And use custom/agnostic sandbox to install those

@xingyaoww xingyaoww enabled auto-merge (squash) July 8, 2024 17:59
@xingyaoww xingyaoww merged commit 351127d into main Jul 8, 2024
@xingyaoww xingyaoww deleted the yufan/runtime-client-image branch July 8, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants