Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tailwind and daisyUI #266

Merged
merged 6 commits into from
Mar 28, 2024
Merged

feat: support tailwind and daisyUI #266

merged 6 commits into from
Mar 28, 2024

Conversation

huybery
Copy link
Collaborator

@huybery huybery commented Mar 27, 2024

As discussed in #217 , supported tailwind and daisyUI and made some styling improvements, not perfect but we can keep iterating.

image

@rbren
Copy link
Collaborator

rbren commented Mar 27, 2024

Looks good overall! Should we just delete the commented code?

frontend/src/App.css Outdated Show resolved Hide resolved
frontend/src/components/CodeEditor.tsx Outdated Show resolved Hide resolved
@huybery
Copy link
Collaborator Author

huybery commented Mar 28, 2024

Looks good overall! Should we just delete the commented code?

The browser part is not known to be implemented at the moment, so I chose to comment it out.

@rbren
Copy link
Collaborator

rbren commented Mar 28, 2024

Fair enough! I typically suggest just deleting code instead of commenting--we can always get back at it through the git history. But either way LGTM!

@huybery huybery merged commit 658b860 into main Mar 28, 2024
@huybery huybery deleted the binyuan-fe branch March 28, 2024 01:44
xcodebuild pushed a commit to xcodebuild/OpenDevin that referenced this pull request Mar 31, 2024
* feat: support tailwind and daisyUI

* feat: some styling improvements with daisyUI

* fix: remove flex in app.css and edit height in CodeEditor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants