Codecov after_n_builds=5 #2468
Merged
Codecov after_n_builds=5 #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingyaoww
approved these changes
Jun 16, 2024
|
Will simultaneous tests across different PRs affect this? Would an alternate solution be merging the reports in the pipeline and upload at once? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Fixes #2369
Basically, codecov uploads results incrementally for larger projects, and if the intermediate result is not good coverage then tests are listed as failing temporarily.
Give a brief summary of what the PR does, explaining any non-trivial design decisions
This uses the codecov
after_n_buildsoption to only report after the five are finished: https://docs.codecov.com/docs/notifications#section-preventing-notifications-until-after-n-buildsCurrently our project is large enough that it uploads 6 reports, so I set this to only update after sending 5/6 (this seems to usually be more than enough to pass our thresholds).
I have confirmed that this does indeed only show codecov after 5 jobs finish, and that that is sufficient to pass tests
Other references
SupersedeS #2462