doc: README displays incorrect env var name #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the report! I think you're right on standardizing. I'm going to close this one in favor of #244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main README instructions say to use Claude or other models should set
export LLM_MODEL='...'but this fails. The
LLM_MODELenv var seems to be the variable for a cmd line parser that is separate from the server for the web app. Not sure as I just started reading the code but maybe going forward you'd like to add a stand alone cmd line program?In any event if users follow the current README it will fail. Just adding this PR to fix quickly so users don't annoyed, but maybe the
MODEL_NAMEandLLM_MODELvars should be changed to the one or the other to avoid confusion?