Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeActSWEAgent to remove browsing & github + improvements on agentskills #2105
Add CodeActSWEAgent to remove browsing & github + improvements on agentskills #2105
Changes from 27 commits
e9d7889
8ec58d2
1e58a12
80c0a33
4aeb002
4f853e7
2a1cc9a
deef10b
7783c10
c2a284f
604c8d9
851df73
6e2736f
a36f6f5
cb23bdb
fa97e57
a98f15a
a9dc3ce
a27b0bb
368f0b9
e699f21
3eaa6fb
832a828
95eb048
a4af937
f6a6854
fdce0ce
9b499e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether should we bump the version
1.6
? The prompts keep the same, but change some logic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly the BrowseInteractiveAction should be remove, is this the case or I simply misunderstood?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my understanding, this agent, CodeAct-SWE, is supposed to know how to browse and use github. It takes over those responsibilities, 'freeing' CodeAct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. I think this should be removed. CodeActSWE does not have the ability to browse.
^ For this reason, how about we starts a separate PR once this is merged to correct all these issues and bump the version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this finish block in use? I cannot see instructions for the model to use
<finish>...</finish>
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! Let's remove it