fix: close runtime after main completion #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought we close it here AgentManeger, and the AgentManager will closed automaticly by atexit. Does it not work correctly? |
|
|
@yufansong @li-boxuan the thing is -- I'm running eval using multi-processing and the program won't terminate until all the eval instances finish running (so no atexit is trigger). I suspect this lead to several instances of OOM in the VM I'm using for eval.. |
li-boxuan
approved these changes
May 17, 2024
yufansong
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the evaluation, I found that the number of browser processes will increase as the evaluation progresses -- until it brings the system to OOM.
I think This PR might fixes this by properly clean-up runtime resource when
mainfinishes.