Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use -it and pull=always for docker #1769

Merged
merged 1 commit into from
May 13, 2024
Merged

use -it and pull=always for docker #1769

merged 1 commit into from
May 13, 2024

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented May 13, 2024

No description provided.

@rbren rbren marked this pull request as ready for review May 13, 2024 21:48
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.19%. Comparing base (b13d464) to head (ac0d0f1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1769   +/-   ##
=======================================
  Coverage   64.19%   64.19%           
=======================================
  Files          99       99           
  Lines        4064     4064           
=======================================
  Hits         2609     2609           
  Misses       1455     1455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume this fixes an open issue

@rbren rbren merged commit 2771328 into main May 13, 2024
2 checks passed
@rbren rbren deleted the rb/docker-run-docs branch May 13, 2024 23:17
@rbren
Copy link
Collaborator Author

rbren commented May 16, 2024

No open issue--just noticed some people getting bit by this in slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants