Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file in _instructions directory not set correctly. #1602

Merged
merged 1 commit into from
May 6, 2024

Conversation

assertion
Copy link
Contributor

For file (not directory) in _instructions, right now just history_truncated.md, the instructions is not set correctly:
image

and the {{ instructions.history_truncated }} in prompt template will not be rendered.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a58f41a). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1602   +/-   ##
=======================================
  Coverage        ?   46.54%           
=======================================
  Files           ?       90           
  Lines           ?     3693           
  Branches        ?        0           
=======================================
  Hits            ?     1719           
  Misses          ?     1974           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@rbren rbren merged commit 2d24521 into All-Hands-AI:main May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants