-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency injection for all objects relying on ObjectSpec #82
Conversation
johnny-bit
commented
Oct 28, 2019
- Changed ObjectSpec to be non-static class
- Removed NASK's ObjectSpec methods to better facilitate new ObjectSpec
- Modified examples to use new ObjectSpec way of doing things
- Removed unnecessary php-version dependent tests due to non-static ObjectSpec
- Added HTTPClient connection example
- Moved COZA extension example to Extension subdir in examples
- Added documentation in README.md
- Added recent changes to CHANGELOG.md
…nd frames and client) * Changed ObjectSpec to be non-static class * Removed NASK's ObjectSpec methods to better facilitate new ObjectSpec * Modified examples to use new ObjectSpec way of doing things * Removed unnecessary php-version dependent tests due to non-static ObjectSpec * Added HTTPClient connection example * Moved COZA extension example to Extension subdir in examples * Added documentation in README.md * Added recent changes to CHANGELOG.md
Amazing work! So the reason As long as it will still be possible? Obviously cleaner to not have them public, but only if we either support all calls, or have an easy way to inject a custom handler? Not sure? |
I wondered about that... Usually one should implement What usecases do you see for them being public? Obviously haing them public because no other class publishes them might also be good idea, so I can add that back, no problem :) |
made them public again :) and done some refactoring, more testing etc :) Should be ready for mainlining. |