Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rotate lazily #190

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

monkeygroover
Copy link
Contributor

@monkeygroover monkeygroover commented Mar 17, 2022

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #190 (63e5ece) into master (e622c65) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          23       23           
  Lines        1974     1974           
=======================================
  Hits         1866     1866           
  Misses        108      108           
Impacted Files Coverage Δ
lib/commands/list_commands.ex 94.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e622c65...63e5ece. Read the comment docs.

@monkeygroover
Copy link
Contributor Author

Didn't mean to include the length(Enum.to_list value) -> Enum.count in the same commit (I was checking it was equivalent), but I think it's the idiomatic way to generically find the length of any enumerable

Copy link
Owner

@Adriandmen Adriandmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @monkeygroover, very nice find!

I remember doing this obscure Stream.map(fn x -> x end) stuff, but I honestly cannot remember why I did that. Either way, looks good to me!

@Adriandmen Adriandmen merged commit 1d532f3 into Adriandmen:master Mar 23, 2022
@monkeygroover monkeygroover deleted the rotate-performance branch March 23, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow performance compared to legacy
2 participants