Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break root hints data out from Perl module #850

Closed
matsduf opened this issue Nov 20, 2020 · 4 comments
Closed

Break root hints data out from Perl module #850

matsduf opened this issue Nov 20, 2020 · 4 comments
Assignees
Labels
T-Feature Type: New feature in software or test case description
Milestone

Comments

@matsduf
Copy link
Contributor

matsduf commented Nov 20, 2020

Root hints data is stored as a data section in Zonemaster/Engine/Recursor.pm. For some use cases it can be useful to be able to change that to private root hints data:

  • DNS training using a private DNS tree including root and TLDs.
  • Zonemaster unit tests making it possible to set up both parent and child in a private tree including TLDs.

To make these use cases possible, put the root hints data was a separate data file. Also make it possible to override that file with a private hints file without updating the perl code.

@matsduf matsduf added T-Feature Type: New feature in software or test case description A-Code labels Nov 20, 2020
@matsduf matsduf added this to the v2020.2 milestone Nov 20, 2020
@mattias-p
Copy link
Member

Ideally we should be keeping around a copy of named.root and parse that during initialization. Given that we can parse it in an acceptable fashion.

@matsduf
Copy link
Contributor Author

matsduf commented Nov 25, 2020

Parsing as such should not be a problem, but keep keeping it in json format is not much extra work since it is not updated often. The question is rather how we are triggered to do the update.

@mattias-p
Copy link
Member

If we keep it in its original format we could have a make target download the current version and diff it against our snapshot.
A possible downside to parsing the original format is that it could introduce additional dependencies.

Another possibility could be if IANA has a mailing list or something for announcements regarding the root hints file.

@matsduf matsduf modified the milestones: v2020.2, v2021.2 Feb 8, 2021
@matsduf matsduf removed the A-Code label Apr 15, 2021
@matsduf matsduf modified the milestones: v2021.2, v2022.1 Dec 8, 2021
@matsduf matsduf modified the milestones: v2022.1, v2022.2 May 21, 2022
@matsduf matsduf self-assigned this Sep 28, 2022
@matsduf matsduf changed the title Break root hint data out from Perl module Break root hints data out from Perl module Sep 28, 2022
@matsduf
Copy link
Contributor Author

matsduf commented Oct 19, 2022

Resolved by #1134

@matsduf matsduf closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Feature Type: New feature in software or test case description
Projects
None yet
Development

No branches or pull requests

2 participants