Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional Net::IP::XS in Backend #688

Closed
mattias-p opened this issue Mar 20, 2020 · 3 comments · Fixed by #689
Closed

Optional Net::IP::XS in Backend #688

mattias-p opened this issue Mar 20, 2020 · 3 comments · Fixed by #689
Milestone
v2020.1

Comments

@mattias-p
Copy link
Member

In order to resolve zonemaster/zonemaster-backend#193 we need to add ip_is_ipv4 to Zonemaster::Net::IP.
@mattias-p mattias-p mentioned this issue Mar 20, 2020
Merged
@matsduf matsduf added this to the v2020.1 milestone Mar 20, 2020
@matsduf matsduf added the A-Code label Mar 20, 2020
@matsduf
Copy link
Contributor

matsduf commented Mar 20, 2020

@mattias-p, what does that have for implications?

@matsduf
Copy link
Contributor

matsduf commented Mar 20, 2020

Resolved by #689

@matsduf matsduf linked a pull request Mar 20, 2020 that will close this issue
Add Zonemaster::Net::IP::ip_is_ipv4 #689
Merged
@mattias-p
Copy link
Member Author

It's just another method in Zonemaster::Net::IP. It won't be called at all by any code in this release.

However after we make the next release, we'd have the option to use the Backend from that release with the Engine from this release in case we need to for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2020.1
Development

Successfully merging a pull request may close this issue.

Add Zonemaster::Net::IP::ip_is_ipv4 mattias-p/zonemaster-engine
2 participants
@mattias-p @matsduf