Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklisting of name servers that do not respond on EDNS queries #513

Closed
matsduf opened this issue Mar 15, 2019 · 2 comments
Closed

Blacklisting of name servers that do not respond on EDNS queries #513

matsduf opened this issue Mar 15, 2019 · 2 comments
Labels
T-Bug Type: Bug in software or error in test case description

Comments

@matsduf
Copy link
Contributor

matsduf commented Mar 15, 2019

There is a function in Engine that blacklists name servers that do not respond. The reason behind that is that it takes time to timeout, and instead of waiting for the same name server not responding several times Engine waits once and remember it.

There are name servers that do not respond on queries with OPT record (instead of returning FORMERR). We do not want to blacklist those. It could be possible to determine is if that kind from result of NAMESERVER02, i.e. if the server does not respond on the query with EDNS but does respond on the query with EDNS, then it should not be blacklisted.

What Test Cases use EDNS? I have identified that NAMESERVER{02,10-14} and DNSSEC** depend on EDNS and could cause unwanted blacklisting.

Also see issue #504.

@matsduf matsduf added the T-Bug Type: Bug in software or error in test case description label Mar 15, 2019
@vlevigneron
Copy link
Contributor

In fact we, as we do for the cache, we blacklist partially a nameserver. For instance, we can blacklist only TCP, not UDP. We can add the same mechanism for EDNS. We just have to pay attention to have few criteria if we want that the mechanism is still efficient.

@matsduf
Copy link
Contributor Author

matsduf commented May 28, 2019

Fixed by #511.

@matsduf matsduf closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Bug Type: Bug in software or error in test case description
Projects
None yet
Development

No branches or pull requests

2 participants