Skip to content
This repository has been archived by the owner on May 16, 2018. It is now read-only.

OpenId tests are failing #291

Closed
mhujer opened this issue Mar 6, 2014 · 3 comments
Closed

OpenId tests are failing #291

mhujer opened this issue Mar 6, 2014 · 3 comments

Comments

@mhujer
Copy link
Contributor

mhujer commented Mar 6, 2014

They are broken since @ezimuel's f6606ff

As they are failing for other reasons on Windows, I'm not able to fix failures on Travis.

@weierophinney
Copy link
Member

Fixed with 8281917

@mhujer
Copy link
Contributor Author

mhujer commented Mar 7, 2014

They still seem to be failing (https://travis-ci.org/zendframework/zf1/jobs/20293893):

There were 4 failures:
1) Zend_Auth_Adapter_OpenIdTest::testAuthenticateVerifyInvalid
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-Signature check failed
+The required parameter op_endpoint is missing in the signed
/home/travis/build/zendframework/zf1/tests/Zend/Auth/Adapter/OpenId/OpenIdTest.php:368
/home/travis/.phpenv/versions/5.2.17/bin/phpunit:46
2) Zend_Auth_Adapter_OpenIdTest::testAuthenticateVerifyGetValid
Failed asserting that false is true.
/home/travis/build/zendframework/zf1/tests/Zend/Auth/Adapter/OpenId/OpenIdTest.php:395
/home/travis/.phpenv/versions/5.2.17/bin/phpunit:46
3) Zend_Auth_Adapter_OpenIdTest::testAuthenticateVerifyPostValid
Failed asserting that false is true.
/home/travis/build/zendframework/zf1/tests/Zend/Auth/Adapter/OpenId/OpenIdTest.php:423
/home/travis/.phpenv/versions/5.2.17/bin/phpunit:46
4) Zend_Auth_Adapter_OpenIdTest::testSetExtensions
Failed asserting that false is true.
/home/travis/build/zendframework/zf1/tests/Zend/Auth/Adapter/OpenId/OpenIdTest.php:457
/home/travis/.phpenv/versions/5.2.17/bin/phpunit:46

@froschdesign froschdesign reopened this Mar 11, 2014
@froschdesign froschdesign modified the milestones: 1.12.6, 1.12.5 Mar 11, 2014
@ezimuel
Copy link
Contributor

ezimuel commented Mar 28, 2014

I just sent the PR #311 to fix the tests.
Note: you need to run the unit test using the --stderr to prevent Session problem (see ZF-8599, http://framework.zend.com/issues/browse/ZF-8599). We have this --stderr in place in runalltests.php.

@ezimuel ezimuel closed this as completed Mar 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants