Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about locust>=0.99 #70

Merged
merged 7 commits into from
Jun 3, 2020
Merged

Warn about locust>=0.99 #70

merged 7 commits into from
Jun 3, 2020

Conversation

thilp
Copy link
Member

@thilp thilp commented Jun 3, 2020

Explain that locust>=0.99 is not yet supported by Transformer when running a Transformer-generated locustfile in locust>=0.99.

Related to #69.

Description

Pending decision and implementation of a longer-term fix (support of v1+, potential deprecation of <0.99), we should mitigate the problem by offering clarity to our users.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

TODO

List of tasks you will do to complete the PR:

  • Update the changelog.

Review

Reviewers' checklist:

  • If this PR implements new flows or changes existing ones, are there
    good tests for these flows?
    If this PR rather removes flows, are the obsolete tests removed as well?
  • Is the documentation still up-to-date and exhaustive? This covers both
    technical (in source files) and functional (under docs/) documentation.
  • Is the changelog updated?
  • Does the new version number correspond to the actual changes from this PR?
    In doubt, refer to https://semver.org.

@zincr
Copy link

zincr bot commented Jun 3, 2020

🤖 zincr found 0 problems , 1 warning

ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

  • ℹ️ poetry.lock had +100 lines of code changed in a single commit
    Please review this file to determine the source of this change
     

@thilp thilp changed the title Warn too recent locust Warn about locust>=0.99 Jun 3, 2020
@thilp thilp marked this pull request as ready for review June 3, 2020 09:11
@thilp thilp requested a review from tortila as a code owner June 3, 2020 09:11
Copy link
Contributor

@tortila tortila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

How funny that they actually released version 0.99 (and 0.999 too, from what I can see), right after 0.14.6

@thilp
Copy link
Member Author

thilp commented Jun 3, 2020

Yes, I think it's a trick to simulate a "redirect" from locustio to locust (not sure why 0.999 in addition to 0.99, though 😄)

@thilp thilp merged commit f567220 into master Jun 3, 2020
@thilp thilp deleted the warn-too-recent-locust branch June 3, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants